Use jnr-posix-api plugin#287
Merged
Merged
Conversation
sarah-witt
added
the
changelog/Changed
sarah-witt
marked this pull request as ready for review
April 8, 2022 15:36
6 tasks
drodriguezhdez
added
the
backward-incompatible
6 tasks
Member
|
BTW |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds jnr-posix-api as a dependency to the plugin and bump the minimum required jenkins version
Description of the Change
Jenkins core removed JNR, and the java dogstatsd client relies on this library. To add the plugin, we need to bump the minimum required jenkins version.
Addresses #285
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
The name of the built-in node changed in more recent versions of jenkins, so we will have to update our tests in order to test them in our jenkinsfile: https://www.jenkins.io/changelog-stable/#v2.319.1
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.