Update Test Connection button text to be more clear#274
Merged
Conversation
yzhan289
added
the
changelog/Fixed
yzhan289
marked this pull request as ready for review
January 26, 2022 21:34
sarah-witt
approved these changes
Jan 26, 2022
drodriguezhdez
approved these changes
Jan 27, 2022
sarah-witt
changed the title
Test Connection button text to be more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes it more clear that the
Test connectionbutton only test theLogs Collection portandTraces Collection port.Description of the Change
The
DogStatsD portis not tested byTest connectionbutton since it is a UDP port. This PR makes it more clear what eachTest connectionbutton does.Additional Notes
#272
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.