Skip to content

Add more error handling on payload creation and add option to not retry sending logs#260

Merged
sarah-witt merged 5 commits into
masterfrom
sarah/improve-loggin-error
Dec 3, 2021
Merged

Add more error handling on payload creation and add option to not retry sending logs#260
sarah-witt merged 5 commits into
masterfrom
sarah/improve-loggin-error

Conversation

@sarah-witt

@sarah-witt sarah-witt commented Nov 30, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

  • Doesn't mutate the payload and add attributes if errors occur on attribute addition
  • Adds more logging around log forwarding
  • check for null values of getHandlers
  • Adds an option in UI and environment variables to not retry sending logs when there's an error

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@sarah-witt sarah-witt changed the title Add more error handling on payload creation and add more logging Add more error handling on payload creation and add option to not retry sending logs Dec 2, 2021
@sarah-witt
sarah-witt marked this pull request as ready for review December 3, 2021 14:40
drodriguezhdez
drodriguezhdez approved these changes Dec 3, 2021
View reviewed changes

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah-witt
sarah-witt merged commit cf41232 into master Dec 3, 2021
@sarah-witt
sarah-witt deleted the sarah/improve-loggin-error branch December 3, 2021 16:56
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Dec 3, 2021
@sarah-witt sarah-witt changed the title Add more error handling on payload creation and add option to not retry sending logs Add more error handling on payload creation and add option to not retry sending logs Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ofek ofek ofek approved these changes
@drodriguezhdez drodriguezhdez drodriguezhdez approved these changes
+1 more reviewer
@coignetp coignetp coignetp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sarah-witt @ofek @coignetp @drodriguezhdez