Send raw git.repository_url in Jenkins pipelines#259
Merged
Conversation
edrevo
approved these changes
Nov 25, 2021
edrevo
left a comment
Contributor
There was a problem hiding this comment.
It might be worth testing this in staging with a very invalid URL to make sure we don't break anything.
AdrianLC
approved these changes
Nov 25, 2021
AdrianLC
left a comment
There was a problem hiding this comment.
do you need the method isValidRepositoryURL for something else? I expected it to be deleted
Collaborator
Author
yeah, we need it to extract the complementary git information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR removes the restriction about sending non-valid repository URL in the
git.repository_urltag for Jenkins pipelines.The repository URL will be treated in the backend and will be discarded if the URL is not valid.
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.