Skip to content

Send raw git.repository_url in Jenkins pipelines#259

Merged
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/send_raw_repository_url
Nov 26, 2021
Merged

Send raw git.repository_url in Jenkins pipelines#259
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/send_raw_repository_url

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR removes the restriction about sending non-valid repository URL in the git.repository_url tag for Jenkins pipelines.
The repository URL will be treated in the backend and will be discarded if the URL is not valid.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@edrevo edrevo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth testing this in staging with a very invalid URL to make sure we don't break anything.

@AdrianLC AdrianLC left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the method isValidRepositoryURL for something else? I expected it to be deleted

@drodriguezhdez

Copy link
Copy Markdown
Collaborator Author

do you need the method isValidRepositoryURL for something else? I expected it to be deleted

yeah, we need it to extract the complementary git information.

@drodriguezhdez
drodriguezhdez merged commit f8bb1f9 into master Nov 26, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/send_raw_repository_url branch November 26, 2021 07:55
@sarah-witt sarah-witt added the changelog/Fixed Fixed features results into a bug fix version bump label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants