Skip to content

Provide option to use Jenkins Credentials for API key input#255

Merged
sarah-witt merged 12 commits into
masterfrom
sarah/add-credentials-api
Nov 29, 2021
Merged

Provide option to use Jenkins Credentials for API key input#255
sarah-witt merged 12 commits into
masterfrom
sarah/add-credentials-api

Conversation

@sarah-witt

@sarah-witt sarah-witt commented Nov 2, 2021

Copy link
Copy Markdown
Collaborator

What does this PR do?

Provides the options for users to store and use their API keys as jenkins credentials in the jenkins UI.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@github-actions github-actions Bot added the documentation Documentation related changes label Nov 2, 2021
@sarah-witt
sarah-witt marked this pull request as ready for review November 3, 2021 19:57
@hithwen hithwen added the changelog/Added Added features results into a minor version bump label Nov 4, 2021

@drodriguezhdez drodriguezhdez left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Have you tested it in a Jenkins instance?

Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
@sarah-witt
sarah-witt merged commit b1f627a into master Nov 29, 2021
@sarah-witt
sarah-witt deleted the sarah/add-credentials-api branch November 29, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump documentation Documentation related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants