Add user.email to the CI Visibility pipeline attributes.#253
Merged
drodriguezhdez merged 1 commit intoOct 25, 2021
Merged
Conversation
cg14823
approved these changes
Oct 25, 2021
Comment on lines
+124
to
+126
| if(StringUtils.isNotEmpty(buildData.getUserEmail(""))){ | ||
| buildSpan.putMeta(CITags.USER_EMAIL, buildData.getUserEmail("")); | ||
| } |
There was a problem hiding this comment.
Nit: I do not know what the Java convention is but would it not be better to store the value of buildData.getUserEmail("") instead of calling it twice?
Collaborator
Author
There was a problem hiding this comment.
I think it's OK to invoke multiple times to a getter.
edrevo
approved these changes
Oct 25, 2021
drodriguezhdez
deleted the
drodriguezhdez/add_user_email_triggered_pipeline
branch
October 25, 2021 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds the
user.emailtag to the pipeline attributes if we can obtain it.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.