Skip to content

Fix enableCiVisibility property to be use for Jenkins configuration-as-code plugin#249

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/jcasc_test
Sep 16, 2021
Merged

Fix enableCiVisibility property to be use for Jenkins configuration-as-code plugin#249
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/jcasc_test

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR fixes the getter method for enableCiVisibility property in the DatadogGlobalConfiguration class to be usable for the configuration-as-code plugin.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
@drodriguezhdez
drodriguezhdez merged commit 46959b0 into master Sep 16, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/jcasc_test branch September 16, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants