Fix ConcurrentModificationException when serializing StepDataAction#243
Merged
drodriguezhdez merged 4 commits intoSep 2, 2021
Merged
Conversation
drodriguezhdez
added
the
changelog/Fixed
added 2 commits
September 2, 2021 11:01
edrevo
reviewed
Sep 2, 2021
| public StepData get(final FlowNode flowNode) { | ||
| return stepDataByDescriptor.get(flowNode.getId()); | ||
| public StepData synchronizedGet(final Run<?,?> run, final FlowNode flowNode) { | ||
| synchronized (run){ |
Contributor
There was a problem hiding this comment.
why are you sych'ing over run and not over the hashmap of the data action?
Collaborator
Author
There was a problem hiding this comment.
Because the lock object is the run instance in the WorkflowRun.save() method.
If we synchronize on the hashmap directly will not resolve the issue, because that is not the lock object used when the action is saved.
edrevo
approved these changes
Sep 2, 2021
drodriguezhdez
deleted the
drodriguezhdez/fix_concurrent_modif_exception
branch
September 2, 2021 11:20
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR adds a
synchronizeon theruninstance on modification of theStepDataActioninternal map.This fixes the race condition detected in a scenario of parallel pipelines, where the
WorkflowRun.save()method raises aConcurrentModificationExceptionbecause the map is modified by otherThread.AIUI
runhere should always be an instance ofWorkflowRun, which synchronizes on itself before saving, which should prevent theConcurrentModificationException.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.