Accept "0" as a valid port value to support UDS#242
Merged
Conversation
java-dogstatsd-client 2.6 and later versions support Unix Domain Socket (UDS). To use this connection method, one must set the port to "0".
|
This issue has been automatically marked as stale because it has not had activity in the last 30 days. |
|
I think this is still a valid requirement :) |
sarah-witt
approved these changes
Dec 17, 2021
sarah-witt
left a comment
sarah-witt
left a comment
Collaborator
There was a problem hiding this comment.
Sorry for the delay in review, this looks good to me!
sarah-witt
added
changelog/Fixed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes port "0" valid, as the java-dogstatsd-client accepts it to support Unix Domain Socket (UDS).
Description of the Change
Any string that can be parsed as a positive integer is considered a valid port.
Alternate Designs
Further improvements could test for
NumberUtils.createInteger(targetPort) <= 65535, unless there are other special values I am not aware of. Also, the current validation does not test for the hostname to correspond to a socket path when the port is set to 0.Possible Drawbacks
None.
Verification Process
None.
Additional Notes
None.
Release Notes
None.
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.