Skip to content

Fix stage breakdown to json conversion#241

Merged
edrevo merged 1 commit into
masterfrom
fix-to-json
Sep 1, 2021
Merged

Fix stage breakdown to json conversion#241
edrevo merged 1 commit into
masterfrom
fix-to-json

Conversation

@edrevo

@edrevo edrevo commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Fix 2 bugs in the toJson logic for stage breakdowns:

  1. String chars need to be escaped or we get invalid json (e.g. if a string contains " or \n)
  2. Span tags cannot be greater than 5000 chars, so when we send huge json messages they get cropped and become invalid. If a json is now greater than 5000 chars, we don't include it.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@edrevo edrevo added changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/normal Normal severity issue labels Aug 26, 2021
@edrevo
edrevo requested a review from drodriguezhdez August 26, 2021 15:16
@edrevo
edrevo merged commit a77d0e3 into master Sep 1, 2021
@edrevo
edrevo deleted the fix-to-json branch September 1, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/normal Normal severity issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants