Skip to content

Exception Logging improvements#24

Merged
gzussa merged 3 commits into
masterfrom
gzu/severe_exceptions
Jan 22, 2020
Merged

Exception Logging improvements#24
gzussa merged 3 commits into
masterfrom
gzu/severe_exceptions

Conversation

@gzussa

@gzussa gzussa commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

What does this PR do?

Print full stack traces and change some warning into severe log levels

Description of the Change

ex.toMessage and ex.toString is not enough.

Verification Process

  • mvn test
  • manual review
  • grep on toMessage

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@gzussa gzussa added the changelog/Added Added features results into a minor version bump label Jan 22, 2020
nmuesch
nmuesch reviewed Jan 22, 2020
View reviewed changes
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
nmuesch
nmuesch previously requested changes Jan 22, 2020
View reviewed changes

@nmuesch nmuesch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple inline comments/questions

Is the empty settings.xml intentional ?

jirikuncar
jirikuncar reviewed Jan 22, 2020
View reviewed changes
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
@gzussa
gzussa requested a review from nmuesch January 22, 2020 21:34
@gzussa
gzussa merged commit 9831e73 into master Jan 22, 2020
@gzussa
gzussa deleted the gzu/severe_exceptions branch January 22, 2020 21:35
@gzussa

gzussa commented Jan 23, 2020

Copy link
Copy Markdown
Contributor Author

sorry @nmuesch i missed your comment about the setting file. I removed it as part of #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkabrda bkabrda Awaiting requested review from bkabrda
@zippolyte zippolyte Awaiting requested review from zippolyte
@nmuesch nmuesch Awaiting requested review from nmuesch
1 more reviewer
@jirikuncar jirikuncar jirikuncar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gzussa @jirikuncar @nmuesch