Skip to content

Add support to the standard Datadog Agent environment variables config.#235

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/add_default_agent_envvars
Jul 27, 2021
Merged

Add support to the standard Datadog Agent environment variables config.#235
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/add_default_agent_envvars

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR adds extends the configuration via environment variables to support the standard ones in Datadog:

  • DD_AGENT_HOST
  • DD_AGENT_PORT
  • DD_TRACE_AGENT_PORT
  • DD_TRACE_AGENT_URL

However, the environment variables with the specific DATADOG_JENKINS_PLUGIN namespace take precedence over the standard ones.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Jul 26, 2021
@github-actions github-actions Bot added the documentation Documentation related changes label Jul 26, 2021
@drodriguezhdez
drodriguezhdez merged commit 95629ed into master Jul 27, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/add_default_agent_envvars branch July 27, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump documentation Documentation related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants