Skip to content

Test connection applies only for TCP ports on Datadog Agent transport mode#232

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/fix_upd_metrics_check_connectivity
Jul 19, 2021
Merged

Test connection applies only for TCP ports on Datadog Agent transport mode#232
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/fix_upd_metrics_check_connectivity

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR applies the following changes:

  • Remove the global Check connectivity button for all configured ports.
  • Add dedicated Test connection buttons only for TCP ports. (Logs and Traces)

The connection cannot be tested for DogStatsD port because is a UDP port.

image

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Related to #231

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez changed the title Test connection only for TCP ports on Datadog Agent transport mode Test connection applies only for TCP ports on Datadog Agent transport mode Jul 16, 2021
@drodriguezhdez
drodriguezhdez merged commit 03d80bf into master Jul 19, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/fix_upd_metrics_check_connectivity branch July 19, 2021 13:33
@drodriguezhdez drodriguezhdez added the changelog/Fixed Fixed features results into a bug fix version bump label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants