Explicitly removal of all invisible actions when a pipeline finishes.#228
Merged
Merged
Conversation
drodriguezhdez
changed the title
drodriguezhdez
added
the
changelog/Fixed
AdrianLC
previously approved these changes
Jul 5, 2021
AdrianLC
left a comment
AdrianLC
left a comment
There was a problem hiding this comment.
It'd be great to have a test checking this
| buildData = new BuildData(run, null); | ||
| } catch (IOException | InterruptedException e) { | ||
| DatadogUtilities.severe(logger, e, "Failed to parse finalized build data"); | ||
| cleanUpTraceActions(run); |
There was a problem hiding this comment.
Isn't the finally below called regardless of the return in this block? That would mean cleaning twice unnecessarily
Collaborator
Author
There was a problem hiding this comment.
Totally correct. I'll remove this.
| // APM Traces | ||
| client.finishBuildTrace(buildData, run); | ||
| logger.fine("End DatadogBuildListener#onFinalized"); | ||
|
|
drodriguezhdez
marked this pull request as draft
July 6, 2021 07:46
Collaborator
Author
I added assertions for this behavior. |
drodriguezhdez
marked this pull request as ready for review
July 6, 2021 08:32
FlorianVeaux
approved these changes
Jul 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR removes explicitly all the
InvisibleActioninstances from theWorkflowRuninstance used by CI Visibility. This is required to avoid memory leaks due to the action instances are not garbage collected, even if the run has finished.As the
onFinalizedmethod is executed before processing the lastFlowNode, we synchronize the clean-up using theIsPipelineAction.Before the fix -> After executing 20 pipelines
After the fix -> After executing 20 pipelines
Related to #227
Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.