Skip to content

Propagate error tags to all node parents for Jenkins Pipelines traces#213

Merged
hithwen merged 2 commits into
masterfrom
drodriguezhdez/propagate_errors
Jun 14, 2021
Merged

Propagate error tags to all node parents for Jenkins Pipelines traces#213
hithwen merged 2 commits into
masterfrom
drodriguezhdez/propagate_errors

Conversation

@drodriguezhdez

@drodriguezhdez drodriguezhdez commented Jun 9, 2021

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR propagates the error tags to all node parents. This allows filtering by ci.status=error on Stages.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Jun 9, 2021
AdrianLC
AdrianLC reviewed Jun 11, 2021
View reviewed changes

@AdrianLC AdrianLC left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there allowed to fail jobs in Jenkins? Have you considered this?

@drodriguezhdez

drodriguezhdez commented Jun 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Are there allowed to fail jobs in Jenkins? Have you considered this?

You can have pipelines with steps where you can catch the error of the step and continue, yes. But in any case, we are propagating the returned result by Jenkins.

  • If Jenkins returns "success", we don't do anything.
  • If Jenkins returns "error", we propagate it through the parent branch.

AFAIK, there is no "allowed to fail" state as we could have in other CI providers.

@hithwen
hithwen merged commit 6edc1fc into master Jun 14, 2021
@hithwen
hithwen deleted the drodriguezhdez/propagate_errors branch June 14, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hithwen hithwen hithwen approved these changes
@mgarabed mgarabed Awaiting requested review from mgarabed
@FlorianVeaux FlorianVeaux Awaiting requested review from FlorianVeaux
+1 more reviewer
@AdrianLC AdrianLC AdrianLC approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@drodriguezhdez @hithwen @AdrianLC