Fix ci.status tag value for skipped Stages on Jenkins Pipelines traces.#206
Merged
Merged
Conversation
drodriguezhdez
force-pushed
the
drodriguezhdez/fix_skipped_stage_result
branch
from
April 29, 2021 14:42
4f4ba3f to
c671b34
Compare
drodriguezhdez
force-pushed
the
drodriguezhdez/fix_skipped_stage_result
branch
from
April 29, 2021 14:56
c671b34 to
5617c98
Compare
FlorianVeaux
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
We need to transform the status reported by Jenkins to a normalized value used across all CI providers. Currently, we're using the Jenkins class
Resultto seek the correct normalized value, but the status reported by the Jenkins Pipelines can returnSKIPPEDstatus, which is not supported byResultclass.In this PR we fix the
ci.statustag value normalization using the String directly, instead of using theResult.fromString(...)method to obtain the returned status.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.