Skip to content

Fix ci.status tag value for skipped Stages on Jenkins Pipelines traces.#206

Merged
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/fix_skipped_stage_result
Apr 30, 2021
Merged

Fix ci.status tag value for skipped Stages on Jenkins Pipelines traces.#206
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/fix_skipped_stage_result

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

We need to transform the status reported by Jenkins to a normalized value used across all CI providers. Currently, we're using the Jenkins class Result to seek the correct normalized value, but the status reported by the Jenkins Pipelines can return SKIPPED status, which is not supported by Result class.

In this PR we fix the ci.status tag value normalization using the String directly, instead of using the Result.fromString(...) method to obtain the returned status.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Fixed Fixed features results into a bug fix version bump label Apr 29, 2021
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/fix_skipped_stage_result branch from 4f4ba3f to c671b34 Compare April 29, 2021 14:42
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/fix_skipped_stage_result branch from c671b34 to 5617c98 Compare April 29, 2021 14:56
@drodriguezhdez
drodriguezhdez merged commit 48b03ba into master Apr 30, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/fix_skipped_stage_result branch April 30, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Fixed Fixed features results into a bug fix version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants