Fix node name propagation on Jenkins pipelines traces#205
Merged
drodriguezhdez merged 13 commits intoApr 30, 2021
Conversation
drodriguezhdez
marked this pull request as ready for review
April 26, 2021 11:01
FlorianVeaux
approved these changes
Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Currently, the node name reported in the indexed spans for Jenkins pipelines doesn't have the correct information because the correct node name information is reported after the
Allocate node : Startchild is executed.This PR fixes the node name information reported in the indexed spans (
pipelineandstage) using the correct node name propagated from the child spans.Description of the Change
We use the following approaches to propagate the correct node name to the indexed spans:
Pipelinespan (root span):PipelineNodeNameInfoActionaction. This action is populated in theDatadogStepListenerlistener taking into account the firstAllocate node : Startflow node that is a child of theStart of Pipelineflow node.Stagesbecause theBuildPipeline#completeInformationmethod because is executed after the root span is sent.Stagespans:BuildPipeline#completeInformationmethod, the executable child node is searched and the node name is propagated to its parent (in this case, the stage we're evaluating)Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.