Remove queue time from spans duration on Jenkins traces#204
Merged
drodriguezhdez merged 5 commits intoApr 26, 2021
Conversation
drodriguezhdez
force-pushed
the
drodriguezhdez/remove_queue_time_span_endtime
branch
from
April 22, 2021 07:59
a423d9b to
ada8071
Compare
added 2 commits
April 22, 2021 11:02
drodriguezhdez
marked this pull request as ready for review
April 22, 2021 09:35
hithwen
approved these changes
Apr 26, 2021
FlorianVeaux
approved these changes
Apr 26, 2021
drodriguezhdez
deleted the
drodriguezhdez/remove_queue_time_span_endtime
branch
April 26, 2021 09:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Currently, the queue time is included in the span duration for those cases where the queue time is reported in a Jenkins internal step (for Jenkins Pipelines).
This happens because the indexed spans don't know the queue time until its
Allocate node : Body : Startnode finishes; this kind of node is a child span from the indexed spans. In these cases, we need to subtract the queue time from the affected spans to obtain a correct span duration.This PR removes the queue time from the duration of the affected spans.
Description of the Change
Pipelineroot span (when necessary).Stagespans (when necessary).Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.