Fix StepData override in DatadogStepListener for Jenkins Pipelines traces#203
Merged
drodriguezhdez merged 1 commit intoApr 22, 2021
Merged
Conversation
FlorianVeaux
approved these changes
Apr 22, 2021
FlorianVeaux
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Good catch with that, I also assumed that the StepDescriptor was unique for a step.
drodriguezhdez
deleted the
drodriguezhdez/fix_step_information_overriden
branch
April 22, 2021 07:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Using the
DatadogStepListenerclass, we're collecting information associated with the actualStepis being executed at that moment, such as environment variables, node name, etc.. in aStepDatainstance. EveryStepDatainstance is kept in a map that will be accessed at the end of the pipeline execution to create the trace.Currently, the key of the map is based on the
StepDescriptor, but Jenkins is reusing the same descriptor for different steps (e.g. the step descriptor of the step representing the Git checkout is the same across the pipeline execution).This PR changes the key of the map to use the
FlowNodeIDs, which are uniques during a certainRun.Description of the Change
The
StepDatamap uses theFlowNodeid (unique) instead of theStepDescriptorin theDatadogStepListenerclass.Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.