Avoid sending jenkins.step.internal spans#202
Merged
Conversation
drodriguezhdez
changed the title
jenkins.step.internal spans
drodriguezhdez
added
the
changelog/Changed
FlorianVeaux
previously approved these changes
Apr 19, 2021
FlorianVeaux
left a comment
FlorianVeaux
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Added a small nit but feel free to disagree and ignore it
| for(final BuildPipelineNode child : current.getChildren()) { | ||
| sendTrace(tracer, buildData, child, parentSpanContext); | ||
| } | ||
| } else { |
Contributor
There was a problem hiding this comment.
nit: you could you return after the for loop instead of this big else block?
Collaborator
Author
There was a problem hiding this comment.
Changed! 👌🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
We've received feedback from alpha customers saying
jenkins.step.internalspans are not so much useful.Additionally, we want to reduce the complexity of recalculating the trace tree when we tackle the issue of removing the queue time from the relevant span duration.
This PR modifies the algorithm that sends the spans of the Jenkins pipelines to avoid sending the
jenkins.step.internalspans.Description of the Change
Added an additional condition in the
isTraceablemethod checking if the node is internal or not. If it's internal, the span is not sent and the algorithm continues with its children.Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.