Skip to content

Remove the exposure of traceIDs as environment variables#196

Merged
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/remove_usage_traceid_private_api
Mar 29, 2021
Merged

Remove the exposure of traceIDs as environment variables#196
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/remove_usage_traceid_private_api

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

  • This PR removes the exposure of trace IDs as environment variables. This approach is no longer valid as we can not apply the same pattern in other CI providers plus, we want to avoid using the usage of private APIs from the Java tracer to set these IDs.
  • The PR removes the changes added in this PR [Expose trace IDs as environment variables #134]

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Removed Deprecated features results into a major version bump label Mar 29, 2021
@drodriguezhdez
drodriguezhdez merged commit 20a8e5b into master Mar 29, 2021
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/remove_usage_traceid_private_api branch March 29, 2021 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Removed Deprecated features results into a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants