Make tasklistener decorator serializable#188
Merged
Merged
Conversation
Collaborator
|
Since the class DatadogTaskListenerDecorator was already technically serializable should we add a test to ensure all the attributes we're interested on are serialized correctly? |
hithwen
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow
DatadogTaskListenerDecoratorto be serializable. It should prevent information loss about the Charset and fix #182Description of the Change
Jenkins sometimes serializes whole classes to send them to the jenkins agents JVM. During that process the
runinstance is null-ed (because not serializable and marked as transient).BuildDatahowever is serializable, so we add the charset info to to this class, and use it instead ofWorkflowRun.Possible Drawbacks
Charsetis not serializable either, so we store the canonical name inBuildData. However it might not cover all the use cases.Other plugins like Logstash are also relying on the canonical name only.
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.