Skip to content

Bug fix when calling fetching build tags from job properties#17

Merged
gzussa merged 1 commit into
masterfrom
gzu/npe
Jan 16, 2020
Merged

Bug fix when calling fetching build tags from job properties#17
gzussa merged 1 commit into
masterfrom
gzu/npe

Conversation

@gzussa

@gzussa gzussa commented Jan 16, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes DataDog/jenkins-datadog-plugin#191

Description of the Change

Check for nulls

Verification Process

Manual review, mvn test, manual test

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@gzussa
gzussa requested a review from zippolyte January 16, 2020 17:43
@gzussa gzussa changed the title fix null pointer exception Fix null pointer exception Jan 16, 2020
@gzussa gzussa changed the title Fix null pointer exception Fix null pointer exception when Job config is non existant Jan 16, 2020
@gzussa gzussa changed the title Fix null pointer exception when Job config is non existant Bug fix when calling fetching build tags from job properties Jan 16, 2020
@gzussa gzussa added changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/major Major severity issue labels Jan 16, 2020
@gzussa
gzussa merged commit 35d981b into master Jan 16, 2020
@gzussa
gzussa deleted the gzu/npe branch January 16, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@zippolyte zippolyte zippolyte approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/Fixed Fixed features results into a bug fix version bump kind/bug Bug related issue severity/major Major severity issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nullpointer when onStarted/onCompleted call the method "getBuildTags"

2 participants

@gzussa @zippolyte