Skip to content

Add stage breakdown to Jenkins Build/Pipelines traces.#158

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/stage_breakdown
Nov 20, 2020
Merged

Add stage breakdown to Jenkins Build/Pipelines traces.#158
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/stage_breakdown

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

This PR adds the Stage breakdown information for Jenkins Build/Pipelines traces.

Description of the Change

The root span includes the tag _dd.ci.stages with the array of all stages (name, duration) serialized in JSON.

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Nov 19, 2020
@drodriguezhdez drodriguezhdez self-assigned this Nov 19, 2020
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/stage_breakdown branch from be45039 to 82a2bbc Compare November 19, 2020 07:57
Comment on lines +7 to +8
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this package need to be added to pom.xml?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed because is inherited by the jenkins dependencies

@drodriguezhdez
drodriguezhdez merged commit d6e5a40 into master Nov 20, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/stage_breakdown branch November 20, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants