Skip to content

Add dec and hex flavour to the environment variable trace IDs.#152

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/trace_envvars_as_decimal
Oct 28, 2020
Merged

Add dec and hex flavour to the environment variable trace IDs.#152
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/trace_envvars_as_decimal

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Thi PR adds the decimal and hexadecimal flavour to the environment variable trace IDs.

  • X_DATADOG_TRACE_ID
  • X_DATADOG_TRACE_ID_HEX
  • X_DATADOG_PARENT_ID
  • X_DATADOG_PARENT_ID_HEX

This PR completes the logic of #134

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez added the changelog/Changed Changed features results into a major version bump label Oct 26, 2020
@drodriguezhdez drodriguezhdez self-assigned this Oct 26, 2020
@drodriguezhdez
drodriguezhdez merged commit 7c687de into master Oct 28, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/trace_envvars_as_decimal branch October 28, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Changed Changed features results into a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants