Skip to content

Add a SKIPPED result status for stages#147

Merged
FlorianVeaux merged 1 commit into
masterfrom
florian/add_skipped_status_for_stages
Oct 16, 2020
Merged

Add a SKIPPED result status for stages#147
FlorianVeaux merged 1 commit into
masterfrom
florian/add_skipped_status_for_stages

Conversation

@FlorianVeaux

@FlorianVeaux FlorianVeaux commented Oct 15, 2020

Copy link
Copy Markdown
Contributor

A bit tricky what's going on here.
First Jenkins on its own does not differentiate in the UI a failed stage in a pipeline from a stage that has been skipped because of an earlier failure.
For example in this job, only the first stage failed but all the others are marked as failed: image

While that's how jobs status are stored by Jenkins, BlueOcean is able to mark those other jobs as "skipped", see:
image

Currently skipped jobs are marked as failed in Datadog, this PR introduces a new tag value "result:SKIPPED" for those jobs

@FlorianVeaux

Copy link
Copy Markdown
Contributor Author

Fix for #146

@mgarabed mgarabed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@patelronak

Copy link
Copy Markdown
Contributor

This is great. Thanks.

@FlorianVeaux

Copy link
Copy Markdown
Contributor Author

Test failure is a windows flake on the jenkins-owned CI. Confirmed working as expected in a lab.

@FlorianVeaux
FlorianVeaux merged commit f013a04 into master Oct 16, 2020
@FlorianVeaux
FlorianVeaux deleted the florian/add_skipped_status_for_stages branch October 16, 2020 07:35
@FlorianVeaux FlorianVeaux added the changelog/Added Added features results into a minor version bump label Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants