Skip to content

Add commit message, author, and committer info to traces#135

Merged
drodriguezhdez merged 6 commits into
masterfrom
drodriguezhdez/traces_git_commit_author
Oct 8, 2020
Merged

Add commit message, author, and committer info to traces#135
drodriguezhdez merged 6 commits into
masterfrom
drodriguezhdez/traces_git_commit_author

Conversation

@drodriguezhdez

@drodriguezhdez drodriguezhdez commented Oct 7, 2020

Copy link
Copy Markdown
Collaborator

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

  • Add commit message, author, and committer info to traces

Description of the Change

This PR search the information related to a certain git commit, and set the correspondent tags in the Jenkins Build/Pipeline traces.

To do that, it uses the JGit API by searching the RevCommit instances associated with a certain git commit, for a certain workspace kept in a certain node. All the information is stored in a GitCommitAction to avoid searching for this information multiple times (this search is expensive).

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez self-assigned this Oct 7, 2020
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/traces_git_commit_author branch from 4dc3b1a to a0e648e Compare October 7, 2020 08:16
@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Oct 7, 2020
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review October 8, 2020 11:02
@drodriguezhdez
drodriguezhdez merged commit 1b9c97d into master Oct 8, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/traces_git_commit_author branch October 8, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants