Expose trace IDs as environment variables#134
Merged
Conversation
FlorianVeaux
approved these changes
Oct 6, 2020
FlorianVeaux
left a comment
Contributor
There was a problem hiding this comment.
Code looks good, can we avoid reflection by adding the appropriate API in datadog.opentracing.OTSpan?
Also could definitely use more tests.
Collaborator
Author
|
I'd say it's not possible to add this API to |
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
This PR exposes the traces ids, such as
trace_idandspan_id, of the traces spans as environment variables.The environment variables are:
X_DATADOG_TRACE_IDfor the traceID.X_DATADOG_PARENT_IDfor the spanID.Those environment variables are available for Jenkins Build span, and for all Jenkins Pipeline workflow steps, setting the correct spanID in the correct step environment.
This feature is required to be able to correlate spans sent from the
datadog-citool.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.