Fix the recover of correct StepData info associated with a Step#123
Merged
Conversation
drodriguezhdez
added
the
changelog/Fixed
drodriguezhdez
marked this pull request as ready for review
September 7, 2020 10:01
mgarabed
suggested changes
Sep 8, 2020
| /** | ||
| * Keeps the Step data during a certain Run. | ||
| */ | ||
| public class StepDataAction extends InvisibleAction implements Serializable { |
Contributor
There was a problem hiding this comment.
This class datasize seems to grow unbounded? Previously, there was a remove method which appeared to keep the data size in check -- will this object go out of scope and be garbage collected at some point?
Collaborator
Author
There was a problem hiding this comment.
There is a new instance of StepDataAction per Run instance and the StepDataAction is bound to the Run instance. I assume that Jenkins will destroy all objects associated with that Run instance once this has finished.
mgarabed
approved these changes
Sep 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing to this repository
What does this PR do?
Description of the Change
A new action called
StepDataActionis used to associate theStepinformation with theFlowNodeinstance based on theStepDescriptor. This allows using information always in the sameRuncontext, avoiding using static accessors (like the classStepDataManager).Finally, the class
StepDataManagerhas been removed.Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.