Skip to content

Add traceID and spanID to every log line.#121

Merged
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/traces_integrate_logs
Sep 3, 2020
Merged

Add traceID and spanID to every log line.#121
drodriguezhdez merged 1 commit into
masterfrom
drodriguezhdez/traces_integrate_logs

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

DISCLAIMER

This PR adds an experimental feature in alpha state.
Internal use only.

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Adds dd.trace_id and dd.span_id of the root span to every reported log line.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez self-assigned this Sep 3, 2020
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review September 3, 2020 15:27
@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Sep 3, 2020
@drodriguezhdez
drodriguezhdez merged commit 1f285f1 into master Sep 3, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/traces_integrate_logs branch September 3, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants