Skip to content

User-defined service name for traces collection#117

Merged
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/user-defined-service
Sep 3, 2020
Merged

User-defined service name for traces collection#117
drodriguezhdez merged 2 commits into
masterfrom
drodriguezhdez/user-defined-service

Conversation

@drodriguezhdez

Copy link
Copy Markdown
Collaborator

DISCLAIMER

This PR adds an experimental feature in alpha state.
Internal use only.

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

Add the configuration logic to allow users to configure the service.name of the APM traces.

Description of the Change

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez self-assigned this Aug 31, 2020
@drodriguezhdez drodriguezhdez added the changelog/Added Added features results into a minor version bump label Aug 31, 2020
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review August 31, 2020 14:19
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/user-defined-service branch from a617905 to 0f9c335 Compare September 3, 2020 12:59
mgarabed
mgarabed previously approved these changes Sep 3, 2020

@mgarabed mgarabed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one minor comment about a comment.

Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/DatadogGlobalConfiguration.java Outdated
@drodriguezhdez

Copy link
Copy Markdown
Collaborator Author

@mgarabed fixed! Can you approve again? Thanks!

@drodriguezhdez
drodriguezhdez merged commit f3e084d into master Sep 3, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/user-defined-service branch September 3, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/Added Added features results into a minor version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants