User-defined service name for traces collection#117
Merged
Conversation
drodriguezhdez
marked this pull request as ready for review
August 31, 2020 14:19
drodriguezhdez
force-pushed
the
drodriguezhdez/user-defined-service
branch
from
September 3, 2020 12:59
a617905 to
0f9c335
Compare
mgarabed
previously approved these changes
Sep 3, 2020
mgarabed
left a comment
Contributor
There was a problem hiding this comment.
LGTM - one minor comment about a comment.
Co-authored-by: Mike Garabedian <[email protected]>
Collaborator
Author
|
@mgarabed fixed! Can you approve again? Thanks! |
mgarabed
approved these changes
Sep 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DISCLAIMER
This PR adds an experimental feature in alpha state.
Internal use only.
Requirements for Contributing to this repository
What does this PR do?
Add the configuration logic to allow users to configure the
service.nameof the APM traces.Description of the Change
Alternate Designs
Possible Drawbacks
Verification Process
Additional Notes
Release Notes
Review checklist (to be filled by reviewers)
changelog/label attached. If applicable it should have thebackward-incompatiblelabel attached.do-not-merge/label attached.kind/andseverity/labels attached at least.