Skip to content

CI-App: Adjust APM traces tags.#111

Merged
drodriguezhdez merged 3 commits into
masterfrom
drodriguezhdez/traces_semantic_conventions
Aug 26, 2020
Merged

CI-App: Adjust APM traces tags.#111
drodriguezhdez merged 3 commits into
masterfrom
drodriguezhdez/traces_semantic_conventions

Conversation

@drodriguezhdez

@drodriguezhdez drodriguezhdez commented Aug 21, 2020

Copy link
Copy Markdown
Collaborator

DISCLAIMER

This PR adds an experimental feature in alpha state.
Internal use only.

Requirements for Contributing to this repository

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only fix one issue at the time.
  • The pull request must update the test suite to demonstrate the changed functionality.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution. For more details, please see CONTRIBUTING.

What does this PR do?

  • Complete APM traces tags based on CI-App semantic conventions.

Description of the Change

Apart from fixing the traces tags keys with the new nomenclature, all tags are normalized among all trace spans.

To do that normalization, the BuildSpanAction has been used to keep a BuildData instance that is updated if some information is not present. (E.g. the Git information is calculated in some inner step when Jenkins is executed in Pipeline mode. In this case, the Git info is stored in the BuildData instance and is available in the root span).

Alternate Designs

Possible Drawbacks

Verification Process

Additional Notes

Release Notes

Review checklist (to be filled by reviewers)

  • Feature or bug fix MUST have appropriate tests (unit, integration, etc...)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have one changelog/ label attached. If applicable it should have the backward-incompatible label attached.
  • PR should not have do-not-merge/ label attached.
  • If Applicable, issue must have kind/ and severity/ labels attached at least.

@drodriguezhdez drodriguezhdez self-assigned this Aug 21, 2020
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/traces_semantic_conventions branch 2 times, most recently from 18a9324 to 13887e5 Compare August 24, 2020 07:27
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/traces_semantic_conventions branch from 13887e5 to 9c62d04 Compare August 24, 2020 07:28
@drodriguezhdez
drodriguezhdez marked this pull request as ready for review August 24, 2020 07:36
Comment thread src/main/java/org/datadog/jenkins/plugins/datadog/traces/BuildSpanAction.java Outdated
@drodriguezhdez
drodriguezhdez force-pushed the drodriguezhdez/traces_semantic_conventions branch from 31a068f to 38f90d0 Compare August 26, 2020 10:20
@drodriguezhdez
drodriguezhdez merged commit 1e0f582 into master Aug 26, 2020
@drodriguezhdez
drodriguezhdez deleted the drodriguezhdez/traces_semantic_conventions branch August 26, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants