In FIPS environment password must be at least 14 characters - #558
Merged
Conversation
Signed-off-by: Olivier Lamy <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return "symbol-id-card"; | ||
| } | ||
|
|
||
| public FormValidation doCheckPassword(@QueryParameter String password) { |
Check warning
Code scanning / Jenkins Security Scan
Stapler: Missing permission check
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
marked this pull request as ready for review
September 12, 2024 23:38
batmat
changed the title
jtnord
reviewed
Sep 13, 2024
…asswordCredentialsImplFIPSTest.java Co-authored-by: James Nord <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
added a commit
to olamy/kubernetes-credentials-plugin
that referenced
this pull request
Sep 17, 2024
Signed-off-by: Olivier Lamy <[email protected]>
jtnord
approved these changes
Sep 17, 2024
| snapshot.setUsernameSecret(credentials.isUsernameSecret()); | ||
| return snapshot; | ||
| } catch (Descriptor.FormException e) { | ||
| throw new RuntimeException(e); |
Member
There was a problem hiding this comment.
weired. I was expecting the method to throw be able to throw an IOException as many credentials can (and are) documented to do that. doc
Member
|
Breaks |
MarkEWaite
added a commit
to MarkEWaite/git-plugin
that referenced
this pull request
Sep 17, 2024
jenkinsci/credentials-plugin#558 shows that there are cases where a longer password is better in the test.
6 tasks
MarkEWaite
added a commit
to jenkinsci/git-plugin
that referenced
this pull request
Sep 17, 2024
jenkinsci/credentials-plugin#558 shows that there are cases where a longer password is better in the test.
olamy
added a commit
to olamy/email-ext-plugin
that referenced
this pull request
Sep 18, 2024
…ode jenkinsci/credentials-plugin#558 Signed-off-by: Olivier Lamy <[email protected]>
6 tasks
slide
pushed a commit
to jenkinsci/email-ext-plugin
that referenced
this pull request
Sep 24, 2024
…ode jenkinsci/credentials-plugin#558 Signed-off-by: Olivier Lamy <[email protected]>
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Sep 28, 2024
https://github.com/jenkinsci/credentials-plugin/releases/tag/1378.v81ef4269d764 includes the change to throw a FormException from the UsernamePasswordCredentialsImpl constructor. Change included in: * jenkinsci/credentials-plugin#558
MarkEWaite
added a commit
to jenkinsci/git-plugin
that referenced
this pull request
Sep 28, 2024
https://github.com/jenkinsci/credentials-plugin/releases/tag/1378.v81ef4269d764 includes changes that throw a Descriptor.FormException from the UsernamePasswordCredentialsImpl constructor. Added in: * jenkinsci/credentials-plugin#558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy [email protected]
Testing done
Submitter checklist