Remove redundant test assertions incompatible with latest credentials plugin#525
Merged
jtnord merged 1 commit intoMar 26, 2026
Merged
Conversation
… plugin Existing assertions already check that the credential usage tracking is correct. The deleted assertions add no real value to the tests and are incompatible with the most recent releases of the credentials plugin. Previously there was an `h2` header with an `id="h2"`. That has been removed while still retaining the rest of the usages data on the page. Detected in plugin BOM pull request: * jenkinsci/bom#6516 Testing done: * Confirmed that tests pass with older credentials plugin and with latest credentials plugin.
Contributor
Author
|
This needs a developer label so that it can be released for inclusion in the plugin BOM this week. @jglick it looks like you are the preferred choice to label and merge this pull request. |
jtnord
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant test assertions incompatible with latest credentials plugin
Existing assertions already check that the credential usage tracking is correct. The deleted assertions add no real value to the tests and are incompatible with the most recent releases of the credentials plugin.
Previously there was an
h2header with anid="h2". That has been removed while still retaining the rest of the usages data on the page.Detected in plugin BOM pull request:
Testing done
Submitter checklist