Preserve setter generic type information during attribute resolution#2867
Merged
Conversation
jetersen
approved these changes
Jul 11, 2026
timja
approved these changes
Jul 11, 2026
timja
left a comment
Member
There was a problem hiding this comment.
thanks, may be worth adding an integration test against priority sorter in a follow up too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2866
This PR fixes a bug in BaseConfigurator where the generic type information declared by a setter could be replaced by the corresponding getter's generic type during attribute resolution.
When a Jenkins plugin declared a broader or wildcard generic type in its setter (for example, List<? extends PriorityStrategy>) but exposed a narrower collection type from its getter, JCasC would use the getter's generic type in place of the setter's declared generic type. As a result, polymorphic HeteroDescribable collections could no longer be configured correctly.
describe() now treats the setter's generic signature as the source of type information. The getter is only used to recover generic information when the setter provides no meaningful generic type.
Testing
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.