Return configuration reload errors as JSON#2864
Merged
Merged
Conversation
timja
reviewed
Jul 6, 2026
timja
reviewed
Jul 6, 2026
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| @RequirePOST | ||
| public void doIndex(StaplerRequest2 request, StaplerResponse2 response) throws IOException { | ||
| public void doIndex(StaplerRequest2 request, StaplerResponse2 response) throws IOException, ServletException { |
Contributor
Author
There was a problem hiding this comment.
This endpoint intentionally implements UnprotectedRootAction and authorizes requests using the configured reload token. The operation is executed only after a constant-time token comparison, so the missing permission-check warning is a false positive.
timja
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2304
Return structured error responses when JCasC reload fails. Return an HTTP 500 response with a JSON error body when a Configuration as Code reload triggered via the reload endpoint fails, rather than a generic server error. This provides clients with actionable error details while preserving successful reload behavior. Add integration tests covering reload failures, JSON error responses, and server-side logging.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.