Use separate classpath JAR for JMH benchmark tests on Windows#2846
Merged
Conversation
Member
|
To confirm, you've tested this on Windows? Have you got a screenshot? |
Contributor
Author
|
I have not tested this locally on Windows. I assumed that if the Windows CI run passes with the change, it would confirm that the issue is resolved, since the failure was specific to the Windows CI environment. If you want, I can also set up a Windows environment locally and verify it directly there. |
Member
|
yes if we see it run on Windows CI that should be fine, looks like the build didn't trigger though |
timja
approved these changes
Jun 6, 2026
timja
left a comment
timja
left a comment
Member
There was a problem hiding this comment.
FWIW Windows builds are incredibly slow on this plugin and we may want to just disable them.
Looks like 5-6 times slower
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows JMH benchmark command-line length issue by enabling jmh.separateClasspathJAR in CascJmhBenchmarkStateTest, allowing benchmark forks to run successfully without hitting an error on Windows CI, and removing the need for the previous workaround skip.
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.