Resolve environment variables before descriptor lookup in HeteroDescribableConfigurator#2805
Merged
Merged
Conversation
Contributor
Author
|
@timja Can you please review this pr? |
timja
approved these changes
Mar 24, 2026
timja
left a comment
timja
left a comment
Member
There was a problem hiding this comment.
thanks, looks reasonable and good test coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve scalar values using SecretSourceResolver before descriptor lookup in HeteroDescribableConfigurator. Previously, values like ${ENV_VAR} were treated as literal symbols, causing lookup failures. This change ensures environment variables are resolved prior to selecting the Describable implementation. The fix includes unit tests in HeteroDescribableConfiguratorTest and has been manually verified via the Jenkins Script Console to instantiate the correct configuration classes.
Fixes #2323
Your checklist for this pull request
🚨 Please review the guidelines for contributing to this repository.