Revert "Update dependency org.jenkins-ci.plugins:ssh-agent to v414" - #7205
Merged
Conversation
…7204)" Rolling back to 402.vc9cec9230d4b_ for the same reason as #7199, which reverted 413: SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped still fails under PCT. 414 could not have fixed it. The 413..414 diff touches only ExecRemoteAgent.java (the "Unify sub-process command execution" refactor, jenkinsci/ssh-agent-plugin#295); SSHAgentStepWorkflowTest.java is byte-identical between the two tags. Reproduced locally against a megawar built from this repo at 414.vc161b_f183543 (PCT checked out c161bf1): [ERROR] Tests run: 42, Failures: 1, Errors: 0, Skipped: 1 [ERROR] SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped Expected: a string containing "Failed to run ssh-agent -k" but: was "... $ ssh-agent -k / Agent pid 1190 killed; / Finished: SUCCESS" The test asserts the build log contains "Failed to run ssh-agent -k", which only happens if the teardown's second "ssh-agent -k" fails. Because ssh-agent daemonizes and is reparented to PID 1, a non-reaping PID 1 leaves the killed agent as a zombie, kill() still succeeds, and the message is never logged. The build itself succeeds; the assertion depends on the reaping behavior of the environment. Extend the Renovate skip range from 403.x-413.x to 403.x-414.x. 415.x and later are still allowed so a fix is picked up automatically. See jenkinsci/ssh-agent-plugin#290 Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
darinpope
changed the title
darinpope
changed the title
timja
approved these changes
Aug 7, 2026
krisstern
approved these changes
Aug 7, 2026
6 tasks
MarkEWaite
pushed a commit
that referenced
this pull request
Aug 9, 2026
…7230)" (#7232) Rolling back to 402.vc9cec9230d4b_ for the same reason as #7205 and #7210: SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped still fails under PCT. 417 could not have fixed it. The 416..417 diff is a single commit, "fix: default ssh-agent timeout when loading legacy job configuration" (jenkinsci/ssh-agent-plugin#300), touching only SSHAgentBuildWrapper.java, ExecRemoteAgent.java, and a new SSHAgentBuildWrapperTimeoutTest.java. SSHAgentStepWorkflowTest.java is byte-identical between the two tags (blob 8b2e0c73836b50ec79b58e6c5b12aed18fe608bb). Reproduced locally against a megawar built from this repo at 417.v1d50b_f28f0e0, run in a container whose PID 1 does not reap: [ERROR] Tests run: 45, Failures: 1, Errors: 0, Skipped: 1 [ERROR] SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped:112 Expected: a string containing "Failed to run ssh-agent -k" but: was "... $ ssh-agent -k / Agent pid 1177 killed; / Finished: SUCCESS" The test asserts the build log contains "Failed to run ssh-agent -k", which only happens if the teardown's second "ssh-agent -k" fails. Because ssh-agent daemonizes and is reparented to PID 1, a non-reaping PID 1 leaves the killed agent as a zombie, kill() still succeeds, and the message is never logged. The build itself succeeds; the assertion depends on the reaping behavior of the environment. The same run against 402.vc9cec9230d4b_ passes: Tests run: 30, Failures: 0, Errors: 0, Skipped: 1. Extend the Renovate skip range from 403.x-416.x to 403.x-417.x. 418.x and later are still allowed so a fix is picked up automatically. See jenkinsci/ssh-agent-plugin#290 Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolling back to
402.vc9cec9230d4b_for the same reason as #7199, which reverted 413: SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped still fails under PCT.414 could not have fixed it. The 413..414 diff touches only ExecRemoteAgent.java (the "Unify sub-process command execution" refactor, jenkinsci/ssh-agent-plugin#295); SSHAgentStepWorkflowTest.java is byte-identical between the two tags.
Reproduced locally against a megawar built from this repo at
414.vc161b_f183543(PCT checked out c161bf1):[ERROR] Tests run: 42, Failures: 1, Errors: 0, Skipped: 1
[ERROR] SSHAgentStepWorkflowTest.teardownDoesNotFailBuildWhenAgentAlreadyStopped
Expected: a string containing "Failed to run ssh-agent -k"
but: was "... $ ssh-agent -k / Agent pid 1190 killed; / Finished: SUCCESS"
The test asserts the build log contains "Failed to run ssh-agent -k", which only happens if the teardown's second "ssh-agent -k" fails. Because ssh-agent daemonizes and is reparented to PID 1, a non-reaping PID 1 leaves the killed agent as a zombie, kill() still succeeds, and the message is never logged. The build itself succeeds; the assertion depends on the reaping behavior of the environment.
Extend the Renovate skip range from 403.x-413.x to 403.x-414.x. 415.x and later are still allowed so a fix is picked up automatically.
See jenkinsci/ssh-agent-plugin#290
Testing done
local testing described above
Submitter checklist