Skip to content

Test latest Jenkins master branch with incremental docker-commons#6516

Closed
MarkEWaite wants to merge 27 commits into
jenkinsci:masterfrom
MarkEWaite:test-stapler-with-commons-logging-1.3.6
Closed

Test latest Jenkins master branch with incremental docker-commons#6516
MarkEWaite wants to merge 27 commits into
jenkinsci:masterfrom
MarkEWaite:test-stapler-with-commons-logging-1.3.6

Conversation

@MarkEWaite

@MarkEWaite MarkEWaite commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Test latest Jenkins master branch with incremental docker-commons

Confirm that commons logging 1.3.6 does not show surprises in plugin BOM tests. Also tests all the recent changes to Jenkins core. This follows the testing that was done in pull request:

Jenkins pull request:

Stapler pull request:

Testing done

  • Confirmed that one test run passed

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@MarkEWaite MarkEWaite added do-not-merge work-in-progress weekly-test Test only the Weekly line in this PR labels Mar 26, 2026
MarkEWaite added a commit to MarkEWaite/oidc-provider-plugin that referenced this pull request Mar 26, 2026
The credentials update test in this plugin fails with the most recent build of Jenkins core from commit:

* jenkinsci/jenkins@0e852bd

with credentials plugin 1498.vd852f8831d79

The failure was first detected in plugin BOM pull request:

* jenkinsci/bom#6516

The failing test is a RealJenkinsRule test that is updating a credential
through the user interface.  The credential update user interface
has improved significantly in the most recent plugin releases.
Those improvements break this test.

Testing done:

The test failure can be seen with the command:

`mvn -Djenkins.version=2.557-rc38112.2dfa_72a_5a_f72 -Dtest=IdTokenCredentialsTest#persistence test`
MarkEWaite added a commit to MarkEWaite/oidc-provider-plugin that referenced this pull request Mar 26, 2026
The credentials update test in this plugin fails with the most recent build of Jenkins core from commit:

* jenkinsci/jenkins@0e852bd

with credentials plugin 1498.vd852f8831d79

The failure was first detected in plugin BOM pull request:

* jenkinsci/bom#6516

The failing test is a RealJenkinsRule test that is updating a credential
through the user interface.  The credential update user interface
has improved significantly in the most recent plugin releases.
Those improvements break this test.

Testing done:

The test failure can be seen with the command:

`mvn -Djenkins.version=2.556 -Dtest=IdTokenCredentialsTest#persistence test`
@MarkEWaite

MarkEWaite commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

The test failure in the OIDC provider plugin is because the plugin uses a UI based test to update a credential and the credential update UI has changed. Fix for the test failure is proposed in OIDC provider pull request:

MarkEWaite added a commit to MarkEWaite/groovy-postbuild-plugin that referenced this pull request Mar 26, 2026
I don't have time to do the research to find a way to fix freestyle
projects that previously used `manager.createSummary()`.  Disabling the
test will only hide the incompatibility.  Users of freestyle projects
that upgrade to badg plugin 3.x will see breaks if they were using
`createSummary()`

Discovered in plugin BOM pull request:

* jenkinsci/bom#6516

Testing done

* Confirmed that the test is disabled for both badge 2.x and badge 3.x
* Failed to find a workaround that will allow freestyle projects to continue adding summaries
MarkEWaite added a commit to jenkinsci/groovy-postbuild-plugin that referenced this pull request Mar 26, 2026
I don't have time to do the research to find a way to fix freestyle
projects that previously used `manager.createSummary()`.  Disabling the
test will only hide the incompatibility.  Users of freestyle projects
that upgrade to badg plugin 3.x will see breaks if they were using
`createSummary()`

Discovered in plugin BOM pull request:

* jenkinsci/bom#6516

Testing done

* Confirmed that the test is disabled for both badge 2.x and badge 3.x
* Failed to find a workaround that will allow freestyle projects to continue adding summaries
MarkEWaite added a commit to MarkEWaite/credentials-binding-plugin that referenced this pull request Mar 26, 2026
… plugin

Existing assertions already check that the credential usage tracking
is correct.  The deleted assertions add no real value to the tests and
are incompatible with the most recent releases of the credentials plugin.

Previously there was an `h2` header with an `id="h2"`.  That has been
removed while still retaining the rest of the usages data on the page.

Detected in plugin BOM pull request:

* jenkinsci/bom#6516

Testing done:

* Confirmed that tests pass with older credentials plugin and with latest
  credentials plugin.
@MarkEWaite

MarkEWaite commented Mar 26, 2026

Copy link
Copy Markdown
Contributor Author

@krisstern the following detected test failures are resolved:

A fix is proposed for:

A similar fix is needed for the failing tests in

@MarkEWaite

Copy link
Copy Markdown
Contributor Author

I submitted a draft pull request to the docker commons plugin to repair some of its tests. At least two of the tests are still failing. Refer to pull request:

@MarkEWaite MarkEWaite changed the title Test stapler with commons logging 1.3.6 Test latest Jenkins master branch with incremental docker-commons Mar 30, 2026
@MarkEWaite

Copy link
Copy Markdown
Contributor Author

Passed tests on ci.jenkins.io, though the notification of the end of the job and final passing test did not seem to reach GitHub. Closing

@MarkEWaite MarkEWaite closed this Mar 30, 2026
@MarkEWaite
MarkEWaite deleted the test-stapler-with-commons-logging-1.3.6 branch March 30, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge weekly-test Test only the Weekly line in this PR work-in-progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant