Merged
Conversation
davidtgoldblatt
approved these changes
Feb 4, 2019
1 task
interwq
added a commit
to interwq/jemalloc
that referenced
this pull request
Oct 4, 2024
It has been disabled since 5.2.0 (in jemalloc#1421).
interwq
added a commit
that referenced
this pull request
Oct 10, 2024
It has been disabled since 5.2.0 (in #1421).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going to do more validation here. So far the consensus seem to say that the 10s muzzy decay is on the aggressive side. We do have a few use cases enabling it explicitly got desired tradeoffs, but given that we don't have a good story on getting accurate RSS accounting with MADV_FREE, and being able to track memory regression is also very valuable, we may want it to be turned off by default in the next release.