Skip to content

Replace decode with decode_www_form_component #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jekyllbot merged 1 commit into from
Jan 11, 2021
Merged

Replace decode with decode_www_form_component #438

jekyllbot merged 1 commit into from
Jan 11, 2021

Conversation

@rubabredwan
Copy link
Contributor

@rubabredwan rubabredwan commented Jan 11, 2021

URI doesn't contain the method decode anymore, raising the error:

/usr/local/lib/ruby/gems/3.0.0/gems/jekyll-import-0.20.0/lib/jekyll-import/importers/blogger.rb:189:in `tag_end': undefined method `decode' for URI:Module (NoMethodError)
  from /usr/local/Cellar/ruby/3.0.0_1/lib/ruby/gems/3.0.0/gems/rexml-3.2.4/lib/rexml/parsers/streamparser.rb:36:in `parse'
  from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-import-0.20.0/lib/jekyll-import/importers/blogger.rb:51:in `block in process'
  from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-import-0.20.0/lib/jekyll-import/importers/blogger.rb:49:in `open'
  from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-import-0.20.0/lib/jekyll-import/importers/blogger.rb:49:in `process'
  from /usr/local/lib/ruby/gems/3.0.0/gems/jekyll-import-0.20.0/lib/jekyll-import/importer.rb:25:in `run'
  from -e:2:in `<main>'

Replacing it with decode_www_form_component which performs the same function.

parkr
parkr approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@parkr
Copy link
Member

parkr commented Jan 11, 2021

@jeyllbot: merge +bug

@jekyllbot jekyllbot merged commit 01bfecf into jekyll:master Jan 11, 2021
jekyllbot added a commit that referenced this pull request Jan 11, 2021
@jekyllbot
Update history to reflect merge of #438 [ci skip]
7b5cc52
@jekyll jekyll locked and limited conversation to collaborators Jan 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@parkr parkr parkr approved these changes

Assignees

No one assigned

Labels

bug fix frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rubabredwan @parkr @jekyllbot