Skip to content

Fix 'can't add a new key into hash during iteration' error #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jekyllbot merged 1 commit into from
May 21, 2020
Merged

Fix 'can't add a new key into hash during iteration' error #434

jekyllbot merged 1 commit into from
May 21, 2020

Conversation

@TheStranjer
Copy link
Contributor

@TheStranjer TheStranjer commented May 12, 2020

When I try to run:

ruby -e 'require "jekyll-import";
    JekyllImport::Importers::WordPress.run({
    # . . .
    })'

Per the instructions found here.

It throws this error:

Traceback (most recent call last):
	4: from -e:2:in `<main>'
	3: from /home/thestranjer/Code/jekyll-import/lib/jekyll-import/importer.rb:22:in `run'
	2: from /home/thestranjer/Code/jekyll-import/lib/jekyll-import/importer.rb:15:in `stringify_keys'
	1: from /home/thestranjer/Code/jekyll-import/lib/jekyll-import/importer.rb:15:in `each_key'
/home/thestranjer/Code/jekyll-import/lib/jekyll-import/importer.rb:16:in `block in stringify_keys': can't add a new key into hash during iteration (RuntimeError)

This is because in the JekyllImport::Importer::stringify_keys method, it is trying to edit the hash as it iterates over itself. This pull request fixes that.

@DirtyF
Copy link
Member

DirtyF commented May 21, 2020

@jekyll: merge +fix

@jekyllbot jekyllbot merged commit c333d71 into jekyll:master May 21, 2020
jekyllbot added a commit that referenced this pull request May 21, 2020
@jekyllbot
Update history to reflect merge of #434 [ci skip]
275b0e7
@TheStranjer TheStranjer deleted the no_new_keys_in_iteration branch May 21, 2020 16:30
@jekyll jekyll locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DirtyF DirtyF DirtyF approved these changes

@ashmaroli ashmaroli ashmaroli approved these changes

Assignees

No one assigned

Labels

bug fix frozen-due-to-age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheStranjer @DirtyF @ashmaroli @jekyllbot