Change data[author] to a string scalar #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the minima template, data[author] is supposed to be a string scala, but the conversion turns it into a map of displayname, author_login and author_email. author_login and author_email are also stored as separate scalar attributes. The fix turns data[author] into a string scalar field of displayname, fixing the display of the author name in the minima template.
Member
|
There was a push to migrate away from the scalar author field and to a hash. I wonder how feasible that is, for example if it’s not backwards compatible then GitHub Pages can’t upgrade. |
Member
@parkr This plugin is not bundled with |
Member
|
@ashmaroli I was more thinking about the minima gem! |
Member
I see.. But Minima doesn't care about |
parkr
approved these changes
Apr 24, 2021
Member
|
@jekyllbot: merge +fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the minima template, data[author] is supposed to be a string scala, but the conversion turns it into a map of displayname, author_login and author_email. author_login and author_email are also stored as separate scalar attributes. The fix turns data[author] into a string scalar field of displayname, fixing the display of the author name in the minima template.