mlock support#9
Closed
evanbattaglia wants to merge 7 commits into
Closed
Conversation
added 3 commits
January 22, 2016 10:42
Never have to go to hard drive (slow)
|
It makes me smile that someone else is using SortDB 👍 |
Contributor
There was a problem hiding this comment.
This comment repeats what Fatalf tells us, so you can probably remove it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C version of sortdb supported a call to mlock to lock the DB file in memory:
https://github.com/bitly/simplehttp/blob/master/sortdb/sortdb.c#L363
This adds this option back in. I'm not sure how much use it will be to others, but it's been useful in ensuring our large DB file is completely loaded in memory before serving and while serving, making sure requests are fast from the start and stay fast.
Note that when using with Docker (at least with large files), the option
--cap-add IPC_LOCKmust be used (Marathon config:parameters: [ { "key": "cap-add", "value": "IPC_LOCK" } ]).The following branch has this and my previous bugfix:
master...seomoz:evan/mlock
CC @noam-c @tony-bye @erinren