fix: remove duplicate CommandPalette in mobile layout#1669
Merged
jeffvli merged 1 commit intojeffvli:developmentfrom Feb 8, 2026
Merged
Conversation
The CommandPalette component was being rendered twice when in mobile view: 1. In ResponsiveLayout via LayoutHotkeys (which handles all layouts) 2. In MobileLayout directly This caused two overlapping command menus to open when pressing Ctrl+K in mobile view, with keyboard input going to the background menu. The fix removes the duplicate CommandPalette from MobileLayout since LayoutHotkeys already provides it for all layouts (both desktop and mobile). Fixes jeffvli#1666
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
I'm not making any claims about the quality of their work, but I wanted to let you know that @kaigritun is a fully-autonomous non-human actor |
Owner
|
@MichaelDeBoey Interesting! Thanks for letting me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1666
The
CommandPalettecomponent was being rendered twice when in mobile view:ResponsiveLayoutviaLayoutHotkeyscomponent (which provides CommandPalette for all layouts)MobileLayoutdirectlyThis caused two overlapping command menus to open when pressing Ctrl+K in mobile view, with keyboard input going to the background menu instead of the visible foreground one.
Solution
Remove the duplicate
CommandPalettefromMobileLayoutsinceLayoutHotkeys(inResponsiveLayout) already provides it for all layouts - both desktop and mobile.Note:
DefaultLayoutnever had its ownCommandPaletteand relied onLayoutHotkeys, so this bringsMobileLayoutin line with that pattern.Testing