Fix: ratings display on player bar and mobile player#1646
Merged
jeffvli merged 2 commits intojeffvli:developmentfrom Feb 4, 2026
Merged
Fix: ratings display on player bar and mobile player#1646jeffvli merged 2 commits intojeffvli:developmentfrom
jeffvli merged 2 commits intojeffvli:developmentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to fix the ratings being displayed on both the player bar and the full screen mobile player when disabled on the user settings. Adresses #1644 introduced by #1426
I decided to add the conditional to
RightControlsto avoidRatingButtonunnecessarily running the code inside it, but if there's another preferable approach such as callinguseGeneralSettingsonPlayerbarinstead and passing the boolean as props, I can adjust it.