fix(Settings): mpv path selector displays wrong default#1641
Merged
jeffvli merged 1 commit intojeffvli:developmentfrom Feb 4, 2026
Merged
fix(Settings): mpv path selector displays wrong default#1641jeffvli merged 1 commit intojeffvli:developmentfrom
jeffvli merged 1 commit intojeffvli:developmentfrom
Conversation
An unnecessary default value appears to be stringifying a Promise when a separate useEffect hook is supposed to properly load the setting value.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
|
Did this change resolve the error for you? I did notice an incorrect path being set as well, which resulted in mpv erroring out in some cases. |
Contributor
Author
|
No, unfortunately it did not. This bug only affects viewing the MPV path from the UI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MPV path setting has a broken default value even though a separate
useEffecthook is supposed to properly load the setting value later.