Use a re-usable Intl.Collator instance for locale compare when possible#1638
Merged
jeffvli merged 2 commits intojeffvli:developmentfrom Feb 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
eramdam
changed the title
eramdam
commented
Feb 2, 2026
Owner
|
Good find on this! I don't think my library was large enough to notice a meaningful difference when this change was added, but the performance benchmark speaks for itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After opening #1637, I tried to run a
git bisectto see when and the UI seemed slower since ~1.3.0. Bisect lead me to this commit that added natural sorting. Unfortunately, usinglocaleCompareon a lot of items in an array isn't free because the JS engine re-creates a new instance ofIntl.Collatorfor every item.This PR fixes that by setting up a re-usable instance of
Intl.Collator()which yields a ~84% speed improvement (when sorting 1,000 items).