feat: add artist radio and track radio (in context menu)#1437
feat: add artist radio and track radio (in context menu)#1437jeffvli merged 17 commits intojeffvli:developmentfrom
Conversation
Co-authored-by: farfromrefug <[email protected]>
…uilding Restore deb package building for Linux
Co-authored-by: farfromrefug <[email protected]>
Co-authored-by: farfromrefug <[email protected]>
Co-authored-by: farfromrefug <[email protected]>
…tist-radio-feature # Conflicts: # src/renderer/api/query-keys.ts # src/renderer/features/artists/components/album-artist-detail-content.tsx # src/renderer/features/settings/components/general/control-settings.tsx # src/renderer/features/songs/api/songs-api.ts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
src/renderer/features/artists/components/album-artist-detail-header.tsx
Outdated
Show resolved
Hide resolved
src/renderer/features/context-menu/actions/play-track-radio-action.tsx
Outdated
Show resolved
Hide resolved
|
@jeffvli i added a new menu entry for artist context menu to start radio. |
src/renderer/features/context-menu/menus/artist-context-menu.tsx
Outdated
Show resolved
Hide resolved
|
Another aspect of this feature that I feel may be desirable is to be able to add the additional play options (play / next / last) when starting the radio, in case the user does not want to overwrite their entire queue. If you don't feel comfortable implementing this, let me know. It's not a requirement, but definitely a nice to have. |
|
@jeffvli i addressed all comments. As per additional play options (play / next / last) to be honest i am not sure what you are thinking about. So i would prefer to leave it to you if that s ok. |
This PR adds:
The artist radio use appropriate API for all server kind.
I am just not sure about the artist radio button style. Could not get it to use the same style as play button. But do we want the same style?
Possible improvements: